Introduce message class resolver#310
Merged
Merged
Conversation
vjik
commented
Jun 15, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ✔️ |
| Tests pass? | ✔️ |
| Fix #292 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
========================================
Coverage 0.00% 0.00%
+ Complexity 336 334 -2
========================================
Files 50 51 +1
Lines 920 918 -2
========================================
+ Misses 920 918 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
samdark
reviewed
Jun 15, 2026
| 'middlewares-push' => [], | ||
| 'middlewares-consume' => [], | ||
| 'middlewares-fail' => [], | ||
| 'message-class-map' => [], |
Member
There was a problem hiding this comment.
Suggested change
| 'message-class-map' => [], | |
| 'messages' => [], |
I'd also move that as 1st array key so it will be message, handlers etc. The drawback here is that we repeat the same thing two times:
'messages' => [
'process-pdf' => ProcessPdfMessage::class,
],
'handlers' => [
'process-pdf' => ProcessPdfMessageHandler::class,
],Could be possibly combined:
'messages' => [
'process-pdf' => [ProcessPdfMessage::class, ProcessPdfMessageHandler::class],
],
Member
Author
There was a problem hiding this comment.
I suggest extracting it into a separate issue.
Member
There was a problem hiding this comment.
Thought more about it. Not a good idea since messages are class-only while handlers are definitions.
samdark
approved these changes
Jun 16, 2026
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.